REFACTOR: change code convention to strict C89 #1

kenter7317 · 2026-04-14T12:10:59Z

kenter7317 commented

2026-04-14 12:10:59 +00:00

this is for refactoring for new domain-specific library(served by repo-owner)-standard

this pull request is proposing variable name refactoring and macro reproduction

variable name renamed following rule

if the variable name is start with single or multiple _, it will be under the process of trim

now some macro has updated

following macros work style is changed

#define prm_cmt PRM_CMT
#define prm_space_found PRM_SPACE_FOUND
#define prm_first PRM_FIRST

orginally refer prm_bool's variable value, but in this refactor has deleted that struct and changed bit-masking, now this refactor macros refer bit-masking-code value and will be work like some operation index and the parameter value is stored in unsigned prm_bool

Example code
original code : prmbool.m_is_bypassing_arg = 1
refactored code : prm_bool |= PRM_IS_BYPASSING_ARG;

following macros are added

8 | #define	STRLEN(a)	((int)(sizeof(a) - 1))

55 | #define BOOL_AND(u, m) ((u) & (m))
56 | #define BOOL_NAND(u, m) ~(BOOL_AND(u, m))

STRLEN(a) is produced for c89's null-terminated size counter
following code has changed :

const char INCLUDE[sizeof("#include")] = "#include";
			char SEE_INC[STRLEN(INCLUDE)];
			size_t i = 1;
			SEE_INC[0] = '#';
			fputc('#', stdout);
			for (; i < (size_t)STRLEN(INCLUDE); i++) {
				SEE_INC[i] = (char)fgetc(stdin);
				fputc(SEE_INC[i], stdout);

				if (SEE_INC[i] != INCLUDE[i]) {
					break;
				}
			}

			if (i == STRLEN(INCLUDE)) {
				while ((c = fgetc(stdin)) != EOF && !isNewLine(c)) {
					fputc(c, stdout);
				}

				puts("\n#undef __ae2f_MACRO_GENERATED\n"
						"#define __ae2f_MACRO_GENERATED 1");
			}
		}

BOOL_AND(u, m) BOOL_NAND(u, m) is macro, for bit-checking and bit adding opeartion

## this is for refactoring for new domain-specific library(served by repo-owner)-standard ## this pull request is proposing variable name refactoring and macro reproduction variable name renamed following rule > if the variable name is start with single or multiple _, it will be under the process of trim ## now some macro has updated following macros work style is changed ``` #define prm_cmt PRM_CMT #define prm_space_found PRM_SPACE_FOUND #define prm_first PRM_FIRST ``` orginally refer prm_bool's variable value, but in this refactor has deleted that struct and changed bit-masking, now this refactor macros refer bit-masking-code value and will be work like some operation index and the parameter value is stored in ```unsigned prm_bool``` > Example code > original code : prmbool.m_is_bypassing_arg = 1 > refactored code : prm_bool |= PRM_IS_BYPASSING_ARG; following macros are added ``` 8 | #define STRLEN(a) ((int)(sizeof(a) - 1)) 55 | #define BOOL_AND(u, m) ((u) & (m)) 56 | #define BOOL_NAND(u, m) ~(BOOL_AND(u, m)) ``` ```STRLEN(a)``` is produced for c89's null-terminated size counter following code has changed : ``` const char INCLUDE[sizeof("#include")] = "#include"; char SEE_INC[STRLEN(INCLUDE)]; size_t i = 1; SEE_INC[0] = '#'; fputc('#', stdout); for (; i < (size_t)STRLEN(INCLUDE); i++) { SEE_INC[i] = (char)fgetc(stdin); fputc(SEE_INC[i], stdout); if (SEE_INC[i] != INCLUDE[i]) { break; } } if (i == STRLEN(INCLUDE)) { while ((c = fgetc(stdin)) != EOF && !isNewLine(c)) { fputc(c, stdout); } puts("\n#undef __ae2f_MACRO_GENERATED\n" "#define __ae2f_MACRO_GENERATED 1"); } } ``` BOOL_AND(u, m) BOOL_NAND(u, m) is macro, for bit-checking and bit adding opeartion

kenter7317 added 3 commits

2026-04-14 12:10:59 +00:00

UPDATE: getting compiler flags ad04aa231e

Changes to be committed:
	- modified:   Macro/CMakeLists.txt
	- modified:   cmake/Macro.cmake

REFACTOR : changing register struct to unsigned variable and rename 57a1a45188

Merge remote-tracking branch 'origin/main' 76baf57830

kenter7317 added 1 commit

2026-04-14 13:05:16 +00:00

FIX : Fix Logical difference error 77df82e12c

kenter7317 commented

2026-04-14 13:09:31 +00:00

i review this commit, some logical error has produced by human trans-logic process, then i fix such error

dalmurii requested changes

2026-04-15 12:40:39 +00:00

dalmurii left a comment

Review 0

Macro/main.c Outdated

					
				@ -23,1 +22,3 @@

				#define prm_first prmbool.m_first

				#define prm_cmt PRM_CMT

				#define prm_space_found PRM_SPACE_FOUND

				#define prm_first PRM_FIRST

For simple lowercase macros seem not to be relevant | required.

Macro/main.c Outdated

					
				@ -75,0 +76,4 @@

					*	unsigned m_is_fn_arg : 1;

					*	unsigned m_is_bypassing_arg : 1;

					* } prmbool = {	0, 0, 0, 0,	0 };

					***/

Original code could be checked via commit.
On comments it is irrelevant.

Original code could be checked via commit. On comments it is irrelevant.

Macro/main.c Outdated

					
				@ -209,2 +219,3 @@

							prm_bool |= PRM_CMT | PRM_FIRST;

							stack = 0;

							prmbool.m_is_fn_arg = 0;

							prm_bool = BOOL_NAND(prm_bool, PRM_IS_FN_ARG);

Logic is wrong.

BOOL_NAND(A, B) is defined ~((A) & (B)) where B is (1 << n).
Which wants to get A's nth bit, and bitnot it.
That will lead ~(1 << n) or ~0(all bit set 1)

Logic is wrong. BOOL_NAND(A, B) is defined ~((A) & (B)) where `B` is `(1 << n)`. Which wants to get `A`'s `n`th bit, and bitnot it. That will lead ~(1 << n) or ~0(all bit set 1)

kenter7317 added 1 commit

2026-04-17 18:13:34 +00:00

FIX : Fix Logical error (NAND process Under whole bit) 889af77628

kenter7317 added 1 commit

2026-04-17 18:17:24 +00:00

DELETE : DELETE unused macro and comment 14ed96dcf8

dalmurii requested changes

2026-04-17 18:20:49 +00:00

Macro/main.c Outdated

					
				@ -52,2 +49,4 @@

				#define isNewLine(c) ((c) == '\n' || (c) == '\r')

				#define BOOL_AND(u, m) ((u) & (m))

				#define BOOL_NAND(u, m) !(BOOL_AND(u, m))

First, that is LOGICAL NOT. The result will be normalised.
Second. pure NAND is not the solution to set a bit 1. See #1 (comment)

First, that is LOGICAL NOT. The result will be normalised. Second. pure NAND is not the solution to set a bit 1. See https://talkischeap.work.gd/ae2f/Preproc/pulls/1#issuecomment-6

after this comment I resolved Logical problem originated at Macro BOOL_NAND and base branch's struct variable's set_zero code that refactored with bit method. See #commit_14ed96dcf8

after this comment I resolved Logical problem originated at Macro BOOL_NAND and base branch's struct variable's set_zero code that refactored with bit method. See [#commit_14ed96dcf8](https://talkischeap.work.gd/ae2f/Preproc/pulls/1/commits/14ed96dcf80794c1feaf8d97a2170c9e05688eff)

kenter7317 added 1 commit

2026-04-17 18:52:35 +00:00

FIX : FIX SET_ZERO logical error 0269e1bd96

kenter7317 added 1 commit

2026-04-20 00:43:39 +00:00

FIX : FIX Fall-trough problem 20bd4c5031

break before fall-through

kenter7317 commented

2026-04-20 00:55:05 +00:00

there are some fall-through porblem only occured at strictC89 until commit #commit_14ed96dcf8, I missed out that problem caused by using bundled gcc and now fixed this problem since commit #commit_20bd4c5031

there are some fall-through porblem only occured at strictC89 until commit [#commit_14ed96dcf8](https://talkischeap.work.gd/ae2f/Preproc/pulls/1/commits/14ed96dcf80794c1feaf8d97a2170c9e05688eff), I missed out that problem caused by using bundled gcc and now fixed this problem since commit [#commit_20bd4c5031](https://talkischeap.work.gd/ae2f/Preproc/pulls/1/commits/20bd4c5031fe11b6999f7c71fd8f9c8c5ecd4ced)

dalmurii requested changes

2026-04-20 01:01:34 +00:00

Macro/main.c Outdated

					
				@ -390,3 +387,3 @@

								fputc(c, stdout);

								c = fgetc(stdin);

								break;

You are adding a break line without handling the default branch.

That could lead to false positives.

You are adding a break line without handling the default branch. That could lead to false positives.

dalmurii commented

2026-04-20 01:04:17 +00:00

Rest of the changes also seem to be adding just break which leads logic to skip the branch which process was to be fallen through, resulting to false positives… fix it.

kenter7317 added 1 commit

2026-04-20 08:49:50 +00:00

FIX : FIX NEEDED Fall-trough Re-implementation 3d59e77c63

break before fall-through and goto fall

dalmurii requested changes

2026-04-20 12:41:36 +00:00

Macro/main.c Outdated

					
				@ -51,29 +48,29 @@ casenewlines

				#define isVarName(c) ((isAlph(c) || isNumber(c)) || (c) == '_')

				#define isNewLine(c) ((c) == '\n' || (c) == '\r')

				#define BOOL_AND(u, m) ((u) & (m))

Inconsistent style. Either use BOOL_OR also or remove this and use pure macro.

Inconsistent style. Either use `BOOL_OR` also or remove this and use pure macro.

Macro/main.c Outdated

					
				@ -53,1 +50,4 @@

				#define BOOL_AND(u, m) ((u) & (m))

				#define SET_ZERO(u, m) ((u) & ~((unsigned)m))

				#define BOOL_OR(u, m) ((u) | (m))

Unused macro. Remove this or use it.

Macro/main.c Outdated

					
				@ -391,2 +391,3 @@

								c = fgetc(stdin);

								goto FALL_STRING_DEFUALT;

								break;

goto does not necessarily require break after itself (it effectively marks the end of the branch)

goto does not necessarily require `break` after itself (it effectively marks the end of the branch)

kenter7317 added 2 commits

2026-04-20 21:08:23 +00:00

REMOVE: REMOVE unnecessary break bbd650b85d

REFACTOR : REFACTOR Macro Style and replace OR call by Macro call setTrue(u, m) cea698b22e

dalmurii commented

2026-04-21 11:15:13 +00:00

Approved

dalmurii merged commit 096efcf2d9 into main

2026-04-21 11:15:18 +00:00

dalmurii referenced this pull request from a commit

2026-04-21 11:15:18 +00:00

Merge pull request 'REFACTOR: change code convention to strict C89' (#1) from kenter7317/Preproc:main into main

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ae2f/Preproc!1

Rows
Columns